-
Notifications
You must be signed in to change notification settings - Fork 285
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create extra samples with surplus images #272
base: main
Are you sure you want to change the base?
Create extra samples with surplus images #272
Conversation
Few questions before I make more changes:
|
Yeah I think we can default to the mmc4 code for all of these. For the first point this should be based on the image size. I think because most vision encoders have size 224x224 we just defaulted to that but that isn't the right way to do it. |
@anas-awadalla here's a first complete draft. please let me know what you think. |
Great will check it tomorrow |
What would the hook contain? The code formatting? |
Yep, kind of like this or whatever else we want. |
This would be awesome! |
@anas-awadalla hoping to get your feedback on this when you get a chance next 🙏 |
Sorry @isaac-chung got busy with a paper I am pushing. I will definitely review and merge this week tho! |
No worries, good luck with the paper! |
@anas-awadalla a gentle nudge to bubble this back up in your inbox. Hoping to close this soon 🙏 |
Addresses issue #231
max_num_images
valid imagespreprocess_gpt_interleaved
andpreprocess_interleaved